[Intel-gfx] [v2] drm/i915/perf: Reverse a ternary to make sparse happy

Chris Wilson chris at chris-wilson.co.uk
Tue Dec 3 09:11:28 UTC 2019


Quoting Nathan Chancellor (2019-12-03 05:05:22)
> On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
> > Avoid
> > 
> > drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
> > 
> > simply by inverting the predicate and reversing the ternary.
> > 
> > v2: More the long lines into their own function so there is no confusion
> > on operator precedence.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> 
> I don't see this applied to drm-intel yet (unless I am blind) and clang
> warns about this as well.

It's in tip. I guess you are looking at the linux-next branch that gets
frozen for the merge window.
-Chris


More information about the Intel-gfx mailing list