[Intel-gfx] [PATCH v3] drm/i915/selftests: add basic selftests for rc6

Andi Shyti andi.shyti at intel.com
Tue Dec 3 11:54:49 UTC 2019


Hi Chris,

> >  }
> > +
> > +static bool test_rc6(struct intel_rc6 *rc6, bool enabled)
> 
> I keep getting confused as to the meaning of the result, forgetting it
> changes based on bool enabled.
> 
> Maybe u32 measure_rc6() and leave the pass/fail to the caller?

yes, I was thinking the same, it makes, indeed more sense.

The original idea was just to know whether rc6 works or not.

Thanks,
Andi


More information about the Intel-gfx mailing list