[Intel-gfx] [PATCH v3 09/12] HID: picoLCD: constify fb ops

Jani Nikula jani.nikula at intel.com
Tue Dec 3 16:38:51 UTC 2019


Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

v2: fix	typo (Christophe de Dinechin)

Cc: Bruno Prémont <bonbons at linux-vserver.org>
Cc: linux-input at vger.kernel.org
Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Acked-by: Bruno Prémont <bonbons at linux-vserver.org>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
 drivers/hid/hid-picolcd_fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index e162a668fb7e..a549c42e8c90 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b/drivers/hid/hid-picolcd_fb.c
@@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)
 	return 0;
 }
 
-/* Note this can't be const because of struct fb_info definition */
-static struct fb_ops picolcdfb_ops = {
+static const struct fb_ops picolcdfb_ops = {
 	.owner        = THIS_MODULE,
 	.fb_destroy   = picolcd_fb_destroy,
 	.fb_read      = fb_sys_read,
-- 
2.20.1



More information about the Intel-gfx mailing list