[Intel-gfx] [PATCH v3 01/13] drm/i915/bios: pass devdata to parse_ddi_port

[Kulkarni, Vandita]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at intel.com>
> Sent: Tuesday, November 26, 2019 7:13 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula at intel.com>; Kulkarni, Vandita
> <vandita.kulkarni at intel.com>; Ville Syrjälä <ville.syrjala at linux.intel.com>
> Subject: [PATCH v3 01/13] drm/i915/bios: pass devdata to parse_ddi_port
> 
> Allow accessing the parent structure later on. Drop const for allowing future
> modification as well.
> 
> Cc: Vandita Kulkarni <vandita.kulkarni at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Looks good to me.
Reviewed-by: Vandita Kulkarni <vandita.kulkarni at intel.com> 

Thanks,
Vandita
> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
> b/drivers/gpu/drm/i915/display/intel_bios.c
> index f6a9a5ccb556..127933f12454 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1525,9 +1525,10 @@ static enum port dvo_port_to_port(u8 dvo_port)
> }
> 
>  static void parse_ddi_port(struct drm_i915_private *dev_priv,
> -			   const struct child_device_config *child,
> +			   struct display_device_data *devdata,
>  			   u8 bdb_version)
>  {
> +	const struct child_device_config *child = &devdata->child;
>  	struct ddi_vbt_port_info *info;
>  	bool is_dvi, is_hdmi, is_dp, is_edp, is_crt;
>  	enum port port;
> @@ -1679,7 +1680,7 @@ static void parse_ddi_port(struct drm_i915_private
> *dev_priv,
> 
>  static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8
> bdb_version)  {
> -	const struct display_device_data *devdata;
> +	struct display_device_data *devdata;
> 
>  	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
>  		return;
> @@ -1688,7 +1689,7 @@ static void parse_ddi_ports(struct
> drm_i915_private *dev_priv, u8 bdb_version)
>  		return;
> 
>  	list_for_each_entry(devdata, &dev_priv->vbt.display_devices, node)
> -		parse_ddi_port(dev_priv, &devdata->child, bdb_version);
> +		parse_ddi_port(dev_priv, devdata, bdb_version);
>  }
> 
>  static void
> --
> 2.20.1