[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Cleanups around intel_attached_encoder() & co. (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 5 11:58:40 UTC 2019


== Series Details ==

Series: drm/i915: Cleanups around intel_attached_encoder() & co. (rev2)
URL   : https://patchwork.freedesktop.org/series/70456/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
832a1c55fe76 drm/i915/hdcp: Nuke intel_hdcp_transcoder_config()
170ec3b713ff drm/i915: Pass intel_connector to intel_attached_*()
-:557: WARNING:LONG_LINE: line over 100 characters
#557: FILE: drivers/gpu/drm/i915/i915_debugfs.c:4512:
+		intel_dp = enc_to_intel_dp(&intel_attached_encoder(to_intel_connector(connector))->base);

total: 0 errors, 1 warnings, 0 checks, 427 lines checked
38feb26c23df drm/i915: Pass intel_encoder to enc_to_*()
-:520: ERROR:CODE_INDENT: code indent should use tabs where possible
#520: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4150:
+^I^I               required_lanes);$

-:520: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#520: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4150:
+	intel_tc_port_get_link(enc_to_dig_port(encoder),
+		               required_lanes);

-:1499: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "hpd_pulse"
#1499: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:305:
+		enc_to_dig_port(encoder)->hpd_pulse != NULL;

total: 1 errors, 0 warnings, 2 checks, 1610 lines checked
767c5765e403 drm/i915: Use the passed in encoder
424e6ca96e88 drm/i915: Use intel_attached_encoder()
-:168: WARNING:LONG_LINE: line over 100 characters
#168: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:508:
+		if (!intel_attached_encoder(connector)->get_hw_state(intel_attached_encoder(connector), &pipe))

total: 0 errors, 1 warnings, 0 checks, 206 lines checked
27e677f40641 drm/i915: Relocate intel_attached_dp()
4e0931881e22 drm/i915: Use intel_attached_dp() instead of hand rolling it
420c21998dbc drm/i915: Rename conn_to_dig_port() to intel_attached_dig_port()
838d626c5ada drm/i915/hdcp: Clean up local variables



More information about the Intel-gfx mailing list