[Intel-gfx] [PATCH] drm/i915: Add Gen/GT info to GPU error state

[John Harrison]

On 11/20/2019 23:23, Chris Wilson wrote:
> Quoting John.C.Harrison at Intel.com (2019-11-21 00:31:42)
>> From: John Harrison <John.C.Harrison at Intel.com>
>>
>> Added gen & GT info to the error capture.
>>
>> Signed-off-by: John Harrison <john.c.harrison at intel.com>
>> CC: Matthew Brost <matthew.brost at intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_gpu_error.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 7118ecb7f144..4c92892d05fb 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -693,6 +693,8 @@ static void __err_print_to_sgl(struct drm_i915_error_state_buf *m,
>>          err_printf(m, "Subplatform: 0x%x\n",
>>                     intel_subplatform(&error->runtime_info,
>>                                       error->device_info.platform));
>> +       err_printf(m, "Gen: %d\n", error->device_info.gen);
> Gen is in the very first line. But repetition is not terrible.
Yeah, it's not particular obvious what the 'ecode' fields are, though.


>> +       err_printf(m, "GT: %d\n", error->device_info.gt);
> device_info is dumped later, but is missing from the printers. It should
> be added there first.
The device_info flags are dumped later but only the flags. Other integer 
fields such as the platform and subplatform are dumped right here. It 
made sense to me to keep all the device identification information 
together - platform, gen, GT, PCI id, etc. All in one place and all nice 
and easy to read.


> -Chris