[Intel-gfx] [PATCH xf86-video-intel 1/2] sna: Fix dirtyfb detection

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 9 15:14:08 UTC 2019


Quoting Ville Syrjala (2019-12-09 15:01:36)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Fix the accidentally swapped bpp and depth values passed to
> the addfb ioctl when we're testing for dirtyfb presence.
> Currently the addfb fails every time so we don't even test
> the actual dirtyfb ioctl.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  src/sna/kgem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/sna/kgem.c b/src/sna/kgem.c
> index 9c0708a635fb..6a35067c4107 100644
> --- a/src/sna/kgem.c
> +++ b/src/sna/kgem.c
> @@ -1538,8 +1538,8 @@ static bool test_has_dirtyfb(struct kgem *kgem)
>         create.width = 32;
>         create.height = 32;
>         create.pitch = 4*32;
> -       create.bpp = 24;
> -       create.depth = 32; /* {bpp:24, depth:32} -> x8r8g8b8 */
> +       create.bpp = 32;
> +       create.depth = 24; /* {bpp:32, depth:24} -> x8r8g8b8 */

I did good.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list