[Intel-gfx] [PATCH 2/2] drm/i915/gt: Move power management debugfs files into gt

Andi Shyti andi at etezian.org
Mon Dec 9 23:39:05 UTC 2019


> > +int intel_gt_pm_debugfs_register(struct intel_gt *gt)
> > +{
> > +       struct drm_minor *minor = gt->i915->drm.primary;
> > +
> > +       return drm_debugfs_create_files(i915_gt_pm_debugfs_list,
> > +                                       ARRAY_SIZE(i915_gt_pm_debugfs_list),
> > +                                       minor->debugfs_root, minor);
> 
> You missed a vital trick to pass the gt as our private. Hint don't use
> drm_debugfs_create_files() per se.

I knew this comment would come, but, after some thoughts, it felt
like this was the less drastic approach (because at the end
nothing really changes :) ).

I will improve it in v2, along with the renaming in patch 1.

Thanks Chris,
Andi


More information about the Intel-gfx mailing list