[Intel-gfx] [PATCH] drm/i915: Use the i915_device name for identifying our request fences

[Chris Wilson]

Quoting Venkata Sandeep Dhanalakota (2019-12-11 15:59:09)
> On 19/12/11 03:02, Chris Wilson wrote:
> > Use the dev_name(i915) to identify the requests for debugging, so we can
> > tell different device timelines apart.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_request.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> > index a6238c626a16..9646e02edea3 100644
> > --- a/drivers/gpu/drm/i915/i915_request.c
> > +++ b/drivers/gpu/drm/i915/i915_request.c
> > @@ -57,7 +57,7 @@ static struct i915_global_request {
> >  
> >  static const char *i915_fence_get_driver_name(struct dma_fence *fence)
> >  {
> > -     return "i915";
> > +     return dev_name(to_request(fence)->i915->drm.dev);
> >  }
> >  
> Sure, should we also update i915_fence_get_timeline_name() 
> return to_request(fence)->gem_context->name ?:
> i915_fence_get_driver_name(fence);

No need really. It's either a user context or a kernel context, the less
said to userspace about internals the better. It will be presented as

00:00:02.00 i915::[i915] (or something like that)

If you would rather that "[i915]" be "[k]" or probably better yet "["
DRIVER_NAME "]"
-Chris