[Intel-gfx] [PATCH 2/2] drm/i915: Make warned variable private

Chris Wilson chris.p.wilson at intel.com
Wed Dec 11 22:22:29 UTC 2019


Quoting Lucas De Marchi (2019-12-11 22:20:13)
> On Wed, Dec 11, 2019 at 04:19:58PM +0000, Chris Wilson wrote:
> >Quoting Chris Wilson (2019-12-11 16:17:23)
> >> Quoting Venkata Sandeep Dhanalakota (2019-12-11 16:07:24)
> >> > Make each instance to report the hang only once.
> >> >
> >> > Cc: Sudeep Dutt <sudeep.dutt at intel.com>
> >> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> >> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> >> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> >> > Cc: Jani Nikula <jani.nikula at intel.com>
> >> > Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota at intel.com>
> >>
> >> I still don't think so, since the we only want to pester the _user_ once
> >> to file a bug, and that is irrespective of the device.
> >
> >Or to put it another way, the dmesg stream is global and this is a flag
> >around that stream.
> 
> maybe we could use WARN_ONCE()?

It's not a warning and doesn't justify being one.
-Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the Intel-gfx mailing list