[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/perf: Register sysctl path globally (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 12 09:37:27 UTC 2019


== Series Details ==

Series: series starting with [1/2] drm/i915/perf: Register sysctl path globally (rev2)
URL   : https://patchwork.freedesktop.org/series/70802/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bea21235639b drm/i915/perf: Register sysctl path globally
9755ac8c9861 drm/i915: Tag GEM_TRACE with device name
-:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'e__' - possible side-effects?
#21: FILE: drivers/gpu/drm/i915/gt/intel_engine.h:32:
+#define ENGINE_TRACE(e__, fmt, ...) do {				\
+	typecheck(struct intel_engine_cs, *(e__));			\
+	GEM_TRACE("%s %s: " fmt, 					\
+		  dev_name((e__)->i915->drm.dev),			\
+		  (e__)->name,						\
+		  ##__VA_ARGS__);					\
+} while (0)

-:23: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#23: FILE: drivers/gpu/drm/i915/gt/intel_engine.h:34:
+^IGEM_TRACE("%s %s: " fmt, ^I^I^I^I^I\$

-:364: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#364: FILE: drivers/gpu/drm/i915/gt/intel_ring_submission.c:769:
+		ENGINE_TRACE(engine, "ring head [%x] not parked\n",
 			  intel_uncore_read_fw(uncore, RING_HEAD(base)));

-:399: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 2 checks, 329 lines checked



More information about the Intel-gfx mailing list