[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev13)

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 12 17:20:51 UTC 2019


== Series Details ==

Series: Refactor Gen11+ SAGV support (rev13)
URL   : https://patchwork.freedesktop.org/series/68028/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
38b8ca097735 drm/i915: Refactor intel_can_enable_sagv
-:208: WARNING:BRACES: braces {} are not necessary for single statement blocks
#208: FILE: drivers/gpu/drm/i915/intel_pm.c:3818:
+		if (latency < dev_priv->sagv_block_time_us) {
+			return;
+		}

-:229: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#229: FILE: drivers/gpu/drm/i915/intel_pm.c:3839:
+	for_each_new_intel_crtc_in_state(state, crtc,
+					     new_crtc_state, i) {

-:431: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#431: FILE: drivers/gpu/drm/i915/intel_pm.c:4430:
+skl_plane_wm_level(struct intel_plane *plane,
+		const struct intel_crtc_state *crtc_state,

-:554: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#554: FILE: drivers/gpu/drm/i915/intel_pm.c:4647:
+			wm_uv_level = skl_plane_wm_level(plane, crtc_state,
+						      level, true);

-:645: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#645: FILE: drivers/gpu/drm/i915/intel_pm.c:5068:
+		skl_compute_plane_wm(crtc_state, 0, latency,
+		     wm_params, &levels[0],

-:647: CHECK:BRACES: Unbalanced braces around else statement
#647: FILE: drivers/gpu/drm/i915/intel_pm.c:5070:
+	} else

-:649: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#649: FILE: drivers/gpu/drm/i915/intel_pm.c:5072:
+		memcpy(&plane_wm->sagv_wm0, &levels[0],
+			sizeof(struct skl_wm_level));

-:729: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#729: FILE: drivers/gpu/drm/i915/intel_pm.c:5765:
+			if (!skl_plane_wm_equals(dev_priv,
+				&old_crtc_state->wm.skl.optimal.planes[plane_id],

-:777: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#777: FILE: drivers/gpu/drm/i915/intel_pm.c:5984:
+				memcpy(&wm->sagv_wm0, &wm->wm[level],
+					sizeof(struct skl_wm_level));

total: 0 errors, 1 warnings, 8 checks, 676 lines checked
e9f893ee788f drm/i915: Restrict qgv points which don't have enough bandwidth.
-:401: CHECK:BRACES: braces {} should be used on all arms of this statement
#401: FILE: drivers/gpu/drm/i915/display/intel_display.c:14914:
+	if (INTEL_GEN(dev_priv) < 11) {
[...]
+	} else
[...]

-:404: CHECK:BRACES: Unbalanced braces around else statement
#404: FILE: drivers/gpu/drm/i915/display/intel_display.c:14917:
+	} else

total: 0 errors, 0 warnings, 2 checks, 396 lines checked
7171528b4b10 drm/i915: Enable SAGV support for Gen12



More information about the Intel-gfx mailing list