[Intel-gfx] [PATCH 08/33] drm/i915/gt: Mark context->state vma as active while pinned

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Dec 12 21:35:00 UTC 2019


On 12/12/2019 21:55, Lionel Landwerlin wrote:
> On 12/12/2019 16:04, Chris Wilson wrote:
>> As we use the active state to keep the vma alive while we are reading
>> its contents during GPU error capture, we need to mark the
>> context->state vma as active during execution if we want to include it
>> in the error state.
>>
>> Reported-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Fixes: b1e3177bd1d8 ("drm/i915: Coordinate i915_active with its own 
>> mutex")
>> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Acked-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com> 


I'm wondering whether we want a test for this or some kind of assert in 
the error capture.

If there is a batch, there must be a context/ring kind of assert.


-Lionel



More information about the Intel-gfx mailing list