[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Some debugfs enhancements (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Dec 13 00:23:34 UTC 2019


== Series Details ==

Series: Some debugfs enhancements (rev2)
URL   : https://patchwork.freedesktop.org/series/70658/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ca6dd2fcb636 drm/i915/rps: Add frequency translation helpers
1529bdcd2469 drm/i915/gt: Move power management debug files into a gt aware debugfs
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

-:34: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/gt/debugfs_gt.c', please use '//' instead
#34: FILE: drivers/gpu/drm/i915/gt/debugfs_gt.c:1:
+/* SPDX-License-Identifier: MIT */

-:34: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#34: FILE: drivers/gpu/drm/i915/gt/debugfs_gt.c:1:
+/* SPDX-License-Identifier: MIT */

-:78: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#78: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:1:
+/*

-:79: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#79: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:2:
+ * SPDX-License-Identifier: MIT

-:170: CHECK:BRACES: braces {} should be used on all arms of this statement
#170: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:93:
+		if (INTEL_GEN(i915) >= 9)
[...]
+		else {
[...]

-:172: CHECK:BRACES: Unbalanced braces around else statement
#172: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:95:
+		else {

-:491: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#491: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:414:
+		gen9_powergate_enable = intel_uncore_read(uncore,
+						GEN9_PG_ENABLE);

-:493: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#493: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:416:
+		gen9_powergate_status = intel_uncore_read(uncore,
+						GEN9_PWRGT_DOMAIN_STATUS);

-:506: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#506: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:429:
+		seq_printf(m, "Render Well Gating Enabled: %s\n",
+			yesno(gen9_powergate_enable & GEN9_RENDER_PG_ENABLE));

-:508: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#508: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:431:
+		seq_printf(m, "Media Well Gating Enabled: %s\n",
+			yesno(gen9_powergate_enable & GEN9_MEDIA_PG_ENABLE));

-:515: CHECK:CAMELCASE: Avoid CamelCase: <GEN6_RCn_MASK>
#515: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:438:
+	switch (gt_core_status & GEN6_RCn_MASK) {

-:540: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#540: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:463:
+		seq_printf(m, "Render Power Well: %s\n",
+			(gen9_powergate_status &

-:543: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#543: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:466:
+		seq_printf(m, "Media Power Well: %s\n",
+			(gen9_powergate_status &

-:677: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#677: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.h:1:
+/*

-:678: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#678: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 7 warnings, 9 checks, 1332 lines checked



More information about the Intel-gfx mailing list