[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Some debugfs enhancements (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Dec 13 17:00:19 UTC 2019


== Series Details ==

Series: Some debugfs enhancements (rev3)
URL   : https://patchwork.freedesktop.org/series/70658/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
459c6bf64d8f drm/i915/rps: Add frequency translation helpers
9bbd26a433a3 drm/i915/gt: Move power management debug files into a gt aware debugfs
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

-:34: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/gt/debugfs_gt.c', please use '//' instead
#34: FILE: drivers/gpu/drm/i915/gt/debugfs_gt.c:1:
+/* SPDX-License-Identifier: MIT */

-:34: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#34: FILE: drivers/gpu/drm/i915/gt/debugfs_gt.c:1:
+/* SPDX-License-Identifier: MIT */

-:91: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#91: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:1:
+/*

-:92: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#92: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:2:
+ * SPDX-License-Identifier: MIT

-:185: CHECK:BRACES: braces {} should be used on all arms of this statement
#185: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:95:
+		if (INTEL_GEN(i915) >= 9)
[...]
+		else {
[...]

-:187: CHECK:BRACES: Unbalanced braces around else statement
#187: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:97:
+		else {

-:516: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#516: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:426:
+		gen9_powergate_enable = intel_uncore_read(uncore,
+						GEN9_PG_ENABLE);

-:518: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#518: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:428:
+		gen9_powergate_status = intel_uncore_read(uncore,
+						GEN9_PWRGT_DOMAIN_STATUS);

-:531: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#531: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:441:
+		seq_printf(m, "Render Well Gating Enabled: %s\n",
+			yesno(gen9_powergate_enable & GEN9_RENDER_PG_ENABLE));

-:533: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#533: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:443:
+		seq_printf(m, "Media Well Gating Enabled: %s\n",
+			yesno(gen9_powergate_enable & GEN9_MEDIA_PG_ENABLE));

-:540: CHECK:CAMELCASE: Avoid CamelCase: <GEN6_RCn_MASK>
#540: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:450:
+	switch (gt_core_status & GEN6_RCn_MASK) {

-:565: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#565: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:475:
+		seq_printf(m, "Render Power Well: %s\n",
+			(gen9_powergate_status &

-:568: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#568: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.c:478:
+		seq_printf(m, "Media Power Well: %s\n",
+			(gen9_powergate_status &

-:723: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#723: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.h:1:
+/*

-:724: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#724: FILE: drivers/gpu/drm/i915/gt/debugfs_pm.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 7 warnings, 9 checks, 1341 lines checked



More information about the Intel-gfx mailing list