[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: Control panel and backlight enable GPIOs from VBT

[Patchwork]

== Series Details ==

Series: drm/i915/dsi: Control panel and backlight enable GPIOs from VBT
URL   : https://patchwork.freedesktop.org/series/70945/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
24c183bed8bd pinctrl: Export pinctrl_unregister_mappings
-:108: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#108: FILE: include/linux/pinctrl/machine.h:156:
+extern void pinctrl_unregister_mappings(const struct pinctrl_map *map);

total: 0 errors, 0 warnings, 1 checks, 80 lines checked
95aabcc5ecf7 drm/i915/dsi: Move poking of panel-enable GPIO to intel_dsi_vbt.c
-:84: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mipi_config->pwm_blc == PPS_BLC_PMIC'
#84: FILE: drivers/gpu/drm/i915/display/intel_dsi_vbt.c:697:
+	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
+	    (mipi_config->pwm_blc == PPS_BLC_PMIC)) {

total: 0 errors, 0 warnings, 1 checks, 128 lines checked
2d9012fa175f drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off
-:70: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "current_mode"
#70: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1910:
+	intel_dsi_vbt_gpio_init(intel_dsi, current_mode != NULL);

total: 0 errors, 0 warnings, 1 checks, 36 lines checked
080c4213d3a7 drm/i915/dsi: Move Crystal Cove PMIC panel GPIO lookup from mfd to the i915 driver
-:78: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mipi_config->pwm_blc == PPS_BLC_PMIC'
#78: FILE: drivers/gpu/drm/i915/display/intel_dsi_vbt.c:732:
+	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
+	    (mipi_config->pwm_blc == PPS_BLC_PMIC))

total: 0 errors, 0 warnings, 1 checks, 93 lines checked
619b4acd14d5 drm/i915/dsi: Control panel and backlight enable GPIOs on BYT