[Intel-gfx] [RFC v2 03/12] drm/i915/svm: Implicitly migrate BOs upon CPU access

Niranjan Vishwanathapura niranjana.vishwanathapura at intel.com
Mon Dec 16 04:17:10 UTC 2019


On Sat, Dec 14, 2019 at 10:58:35AM +0000, Chris Wilson wrote:
>Quoting Niranjana Vishwanathapura (2019-12-13 21:56:05)
>> +int i915_gem_object_migrate_region(struct drm_i915_gem_object *obj,
>> +                                  u32 *regions, int size)
>> +{
>> +       struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
>> +       struct intel_context *ce = dev_priv->engine[BCS0]->kernel_context;
>> +       int i, ret;
>> +
>>         mutex_lock(&dev_priv->drm.struct_mutex);
>>         ret = i915_gem_object_prepare_move(obj);
>
>You appear to be based on a very broken code base. I'd recommend not
>doing that.

Yah, this patch is dependent on the object migration support posted in LMEM
patch series. I only included this for RFC to give a full picture.

Niranjana

>-Chris



More information about the Intel-gfx mailing list