[Intel-gfx] [PATCH] drm/i915/gem: Serialise object before changing cache-level

Andi Shyti andi.shyti at intel.com
Mon Dec 16 10:56:50 UTC 2019


Hi Chris,

On Fri, Dec 13, 2019 at 10:31:40PM +0000, Chris Wilson wrote:
> Wait for the object to be idle before changing its cache-level and
> unbinding. This was dropped as supposedly superfluous from commit
> 8b1c78e06e61 ("drm/i915: Avoid calling i915_gem_object_unbind holding
> object lock"), but it turns out to prevent some cache dirt escaping.
> Smells like papering over a race...
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/820
> Fixes: 8b1c78e06e61 ("drm/i915: Avoid calling i915_gem_object_unbind holding object lock")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti at intel.com>

Acked-by: Andi Shyti <andi.shyti at intel.com>

Thanks,
Andi


More information about the Intel-gfx mailing list