[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add lmem fault handler

Patchwork patchwork at emeril.freedesktop.org
Tue Dec 17 12:37:28 UTC 2019


== Series Details ==

Series: series starting with [1/2] drm/i915: Add lmem fault handler
URL   : https://patchwork.freedesktop.org/series/71051/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
21b92ebb9c01 drm/i915: Add lmem fault handler
-:116: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#116: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:303:
+		return i915_error_to_vmf_fault(ret);
+	} else {

-:118: WARNING:LINE_SPACING: Missing a blank line after declarations
#118: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:305:
+		vm_fault_t vmf_ret = VM_FAULT_SIGBUS;
+		if (GEM_WARN_ON(size < PAGE_SIZE))

-:151: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:742:
+       .fault = vm_fault_iomem,$

-:152: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:743:
+       .open = vm_open,$

-:153: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:744:
+       .close = vm_close,$

total: 0 errors, 5 warnings, 0 checks, 157 lines checked
ded079f2d6fc drm/i915/selftests: Add selftest for memory region PF handling



More information about the Intel-gfx mailing list