[Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling

Chris Wilson chris at chris-wilson.co.uk
Wed Dec 18 17:10:47 UTC 2019


Quoting Tvrtko Ursulin (2019-12-18 16:48:20)
> 
> On 17/12/2019 09:56, Chris Wilson wrote:
> > Only signal the breadcrumbs from inside the irq_work, simplifying our
> > interface and calling conventions. The micro-optimisation here is that
> > by always using the irq_work interface, we know we are always inside an
> > irq-off critical section for the breadcrumb signaling and can ellide
> > save/restore of the irq flags.
> 
> Assuming no significant impact on saturated media workloads:

v5.5-rc1 and v5.5-rc2 have been quite a rollercoaster; but this patch
does not seem to affect wsim, apart from making the flamegraphs tidier.
-Chris


More information about the Intel-gfx mailing list