[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP Phy compliance auto test

Patchwork patchwork at emeril.freedesktop.org
Wed Dec 18 18:42:37 UTC 2019


== Series Details ==

Series: DP Phy compliance auto test
URL   : https://patchwork.freedesktop.org/series/71121/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b177259a3656 drm/dp: get/set phy compliance pattern
701d1cb86d03 drm/amd/display: Fix compilation issue.
b553ef602d04 drm/i915/dp: Move vswing/pre-emphasis adjustment calculation
0f5e33d5d6c0 drm/i915/dp: Preparation for DP phy compliance auto test
391d0f4e1225 drm/i915/dsb: Send uevent to testapp.
5ba33dc9aa02 drm/i915/dp: Add debugfs entry for DP phy compliance.
ee3972d67e5d drm/i915/dp: Register definition for DP compliance register
644f91780a71 drm/i915/dp: Update the pattern as per request
c81ef6762f12 drm/i915/dp: [FIXME] Program vswing, pre-emphasis, test-pattern
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
series. Some temporary fix added and the patch is under-development, not for

-:40: ERROR:SPACING: space required before the open parenthesis '('
#40: FILE: drivers/gpu/drm/i915/display/intel_display.c:14670:
+	if(dev_priv->dp_phy_comp) {

-:66: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:14907:
+	if (!dev_priv->dp_phy_comp) {
 	i915_sw_fence_init(&state->commit_ready,

-:80: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#80: FILE: drivers/gpu/drm/i915/display/intel_display.c:14952:
+	if (!dev_priv->dp_phy_comp) {
 	if (ret) {

-:97: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#97: FILE: drivers/gpu/drm/i915/display/intel_display.c:14980:
+	if (!dev_priv->dp_phy_comp) {
 	i915_sw_fence_commit(&state->commit_ready);

-:97: WARNING:BRACES: braces {} are not necessary for single statement blocks
#97: FILE: drivers/gpu/drm/i915/display/intel_display.c:14980:
+	if (!dev_priv->dp_phy_comp) {
 	i915_sw_fence_commit(&state->commit_ready);
+	}

total: 1 errors, 5 warnings, 0 checks, 181 lines checked



More information about the Intel-gfx mailing list