[Intel-gfx] [PATCH 0/5] display: prefer 3-letter acronym

[Lucas De Marchi]

On Wed, Dec 18, 2019 at 04:27:30PM -0800, Lucas De Marchi wrote:
>On Wed, Dec 18, 2019 at 08:07:55AM +0200, Jani Nikula wrote:
>>On Tue, 17 Dec 2019, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>>>This bothered me for a while so I decided to give it a try: let's
>>>normalize on using the platform acronym for function prefixes.
>>
>>The mixed use has always bothered me too.
>>
>>Acked-by: Jani Nikula <jani.nikula at intel.com>
>>
>>(Up next, IS_BROADWELL vs. IS_BDW_ULT etc... ;)
>
>actually next are the functions using <platform>_ prefix. I will leave
>the IS_* macros for later or bundle them in the respective commits (not
>that I didn't change IS_ICELAKE, IS_TIGERLAKE, etc.  Maybe it's a good
>idea to just bundle them in next iteration.
>

also I was concentrating only on display/. If we are to change all the
IS_* macros this has to be done in the entire driver.  Do you think it
belongs in the same commit? It will be pretty intrusive.

Lucas De Marchi

>thanks
>Lucas De Marchi
>
>
>>
>>
>>>
>>>This does the conversion for some platforms. There are others missing,
>>>but I'm sending this early for the case the idea is shot down.
>>>
>>>Lucas De Marchi (5):
>>>  drm/i915/display: prefer 3-letter acronym for haswell
>>>  drm/i915/display: prefer 3-letter acronym for skylake
>>>  drm/i915/display: prefer 3-letter acronym for cannonlake
>>>  drm/i915/display: prefer 3-letter acronym for icelake
>>>  drm/i915/display: prefer 3-letter acronym for ironlake
>>>
>>> drivers/gpu/drm/i915/display/intel_crt.c      |   6 +-
>>> drivers/gpu/drm/i915/display/intel_ddi.c      |   4 +-
>>> drivers/gpu/drm/i915/display/intel_display.c  | 278 +++++++++---------
>>> drivers/gpu/drm/i915/display/intel_display.h  |   2 +-
>>> drivers/gpu/drm/i915/display/intel_dp.c       |  34 +--
>>> .../drm/i915/display/intel_fifo_underrun.c    |   6 +-
>>> 6 files changed, 163 insertions(+), 167 deletions(-)
>>
>>-- 
>>Jani Nikula, Intel Open Source Graphics Center