[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Render/media decompression support (rev3)

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 19 01:05:25 UTC 2019


== Series Details ==

Series: drm/i915/tgl: Render/media decompression support (rev3)
URL   : https://patchwork.freedesktop.org/series/71125/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0db89922ad4d drm/framebuffer: Format modifier for Intel Gen-12 render compression
fdc1e07ba896 drm/i915: Use intel_tile_height() instead of re-implementing
ed420ff5d644 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment
6dfdc0daaf3f drm/i915: Extract framebufer CCS offset checks into a function
a5ee2996f222 drm/i915: Add helpers to select correct ccs/aux planes
0754fb06980e drm/i915/tgl: Gen-12 render decompression
-:287: ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: drivers/gpu/drm/i915/display/intel_display.c:2802:
+^I        drm_format_info_block_width(fb->format, main_plane);$

total: 1 errors, 0 warnings, 0 checks, 434 lines checked
9e84b5f36583 drm/i915/tgl: Make sure FBs have a correct CCS plane stride
fe895b490e63 drm/i915: Skip rotated offset adjustment for unsupported modifiers
5f3205fa6fef drm/i915: Make sure Y slave planes get all the required state
586b5fcb3735 drm/i915: Make sure CCS YUV semiplanar format checks work
-:54: ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: drivers/gpu/drm/i915/display/intel_display.c:3856:
+^I^I^I^I^I        fb->modifier)) {$

-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/display/intel_display.c:3856:
+	if (intel_format_info_is_yuv_semiplanar(fb->format,
+					        fb->modifier)) {

-:64: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#64: FILE: drivers/gpu/drm/i915/display/intel_display.c:5786:
+		  uint64_t modifier, bool need_scaler)

total: 1 errors, 0 warnings, 2 checks, 142 lines checked
740c4f7ff980 drm/framebuffer: Format modifier for Intel Gen-12 media compression
b816e143d098 drm/fb: Extend format_info member arrays to handle four planes
2add322e7188 drm/i915/tgl: Gen-12 display can decompress surfaces compressed by the media engine
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13: 
compressed buffers. Unlike render decompression, plane 6 and  plane 7 do not

-:111: WARNING:MISSING_BREAK: Possible switch case/default not preceded by break or fallthrough comment
#111: FILE: drivers/gpu/drm/i915/display/intel_display.c:2635:
+	case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:

total: 0 errors, 2 warnings, 0 checks, 487 lines checked
ffc858def370 drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color
d3ec1213283b drm/i915/tgl: Add Clear Color support for TGL Render Decompression
-:304: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#304: FILE: drivers/gpu/drm/i915/i915_reg.h:6889:
+#define PLANE_CC_VAL(pipe, plane)	\
+	_MMIO_PLANE(plane, _PLANE_CC_VAL_1(pipe), _PLANE_CC_VAL_2(pipe))

total: 0 errors, 0 warnings, 1 checks, 238 lines checked



More information about the Intel-gfx mailing list