[Intel-gfx] [PATCH 4/8] drm/gem-fb-helper: convert to drm device based logging

[Jani Nikula]

On Tue, 17 Dec 2019, Sam Ravnborg <sam at ravnborg.org> wrote:
> On Tue, Dec 10, 2019 at 02:30:46PM +0200, Jani Nikula wrote:
>> Prefer drm_dbg_kms() and drm_err() over all other logging.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> Reviewed-by: Sam Ravnborg <sam at ravnborg.org>

Thanks for the review, pushed up to this patch.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> index b9bcd310ca2d..3a7ace19a902 100644
>> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> @@ -74,8 +74,7 @@ drm_gem_fb_alloc(struct drm_device *dev,
>>  
>>  	ret = drm_framebuffer_init(dev, fb, funcs);
>>  	if (ret) {
>> -		DRM_DEV_ERROR(dev->dev, "Failed to init framebuffer: %d\n",
>> -			      ret);
>> +		drm_err(dev, "Failed to init framebuffer: %d\n", ret);
>>  		kfree(fb);
>>  		return ERR_PTR(ret);
>>  	}
>> @@ -160,7 +159,7 @@ drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file,
>>  
>>  		objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);
>>  		if (!objs[i]) {
>> -			DRM_DEBUG_KMS("Failed to lookup GEM object\n");
>> +			drm_dbg_kms(dev, "Failed to lookup GEM object\n");
>>  			ret = -ENOENT;
>>  			goto err_gem_object_put;
>>  		}
>> -- 
>> 2.20.1
>> 
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Graphics Center