[Intel-gfx] [PATCH 3/3] drm/i915: reimplement header test feature

Chris Wilson chris at chris-wilson.co.uk
Thu Dec 19 17:00:33 UTC 2019


Quoting Jani Nikula (2019-12-19 15:56:52)
> From: Masahiro Yamada <yamada.masahiro at socionext.com>
> 
> I implemented a small build rule in drivers/gpu/drm/i915/Makefile
> without relying on the special header-test-y syntax that was removed in
> commit fcbb8461fd23 ("kbuild: remove header compile test").
> 
> I excluded some headers from the test coverage. I hope somebody
> intrested can take a closer look at them.
> 
> Dummy subdir Makefiles can be removed altogether as single target build
> use case is now covered by commit 394053f4a4b3 ("kbuild: make single
> targets work more correctly").
> 
> v2 by Jani:
> - add selftests/i915_perf_selftests.h to no-header-test
> - add .gitignore for *.hdrtest
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Whelp, I guess that explains why CI didn't tell me off for breaking the
self-contained headers. The pattern matching works, I didn't see any
residue after a make clean, and git status is not swamped with the
artifacts. Single object build still works. O=_build still works
(O=_build -j10 did not, hopefully that is not significant???)

Everything looks (mostly) in order,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list