[Intel-gfx] [PATCH 1/2] drm/i915: Add spaces before compound GEM_TRACE

[Chris Wilson]

Quoting Lucas De Marchi (2019-12-23 21:23:36)
> On Mon, Dec 23, 2019 at 08:44:10PM +0000, Chris Wilson wrote:
> >Add a space between the prefixed format and the users format so that the
> >join are not mistakenly combined into one long word.
> >
> >Fixes: 639f2f24895f ("drm/i915: Introduce new macros for tracing")
> >Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >Cc: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota at intel.com>
> >---
> > drivers/gpu/drm/i915/gt/intel_context.h | 2 +-
> > drivers/gpu/drm/i915/i915_request.h     | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h
> >index 1d4a1b1357cf..0f5ae4ff3b10 100644
> >--- a/drivers/gpu/drm/i915/gt/intel_context.h
> >+++ b/drivers/gpu/drm/i915/gt/intel_context.h
> >@@ -19,7 +19,7 @@
> >
> > #define CE_TRACE(ce, fmt, ...) do {                                   \
> >       const struct intel_context *ce__ = (ce);                        \
> >-      ENGINE_TRACE(ce__->engine, "context:%llx" fmt,                  \
> >+      ENGINE_TRACE(ce__->engine, "context:%llx " fmt,                 \
> >                    ce__->timeline->fence_context,                     \
> >                    ##__VA_ARGS__);                                    \
> > } while (0)
> >diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
> >index 565322640378..9784421a3b4d 100644
> >--- a/drivers/gpu/drm/i915/i915_request.h
> >+++ b/drivers/gpu/drm/i915/i915_request.h
> >@@ -51,7 +51,7 @@ struct i915_capture_list {
> >
> > #define RQ_TRACE(rq, fmt, ...) do {                                   \
> >       const struct i915_request *rq__ = (rq);                         \
> >-      ENGINE_TRACE(rq__->engine, "fence %llx:%lld, current %d" fmt,   \
> >+      ENGINE_TRACE(rq__->engine, "fence %llx:%lld, current %d " fmt,  \
> 
> do we care about the trailing space if fmt is "\n"?

No. An extra space in a debug log, which you only see when something
blows up and only compiled in for CI, is the last of your worries.
-Chris