[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP Phy compliance auto test (rev5)

Patchwork patchwork at emeril.freedesktop.org
Mon Dec 30 16:57:00 UTC 2019


== Series Details ==

Series: DP Phy compliance auto test (rev5)
URL   : https://patchwork.freedesktop.org/series/71121/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8a55c99e987a drm/amd/display: Align macro name as per DP spec
b46d414a1888 drm/dp: get/set phy compliance pattern
eaa338c1dc20 drm/i915/dp: Move vswing/pre-emphasis adjustment calculation
d7fed7271de6 drm/i915/dp: Preparation for DP phy compliance auto test
24a9becfee75 drm/i915/dsb: Send uevent to testapp.
82604acfc432 drm/i915/dp: Add debugfs entry for DP phy compliance.
379c984a0e16 drm/i915/dp: Register definition for DP compliance register
8b30e6e85d43 drm/i915/dp: Update the pattern as per request
ebbce9a8cc0e drm/i915/dp: [FIXME] Program vswing, pre-emphasis, test-pattern
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
series. Some temporary fix added and the patch is under-development, not for

-:40: ERROR:SPACING: space required before the open parenthesis '('
#40: FILE: drivers/gpu/drm/i915/display/intel_display.c:15219:
+	if(dev_priv->dp_phy_comp) {

-:66: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:15456:
+	if (!dev_priv->dp_phy_comp) {
 	i915_sw_fence_init(&state->commit_ready,

-:80: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#80: FILE: drivers/gpu/drm/i915/display/intel_display.c:15501:
+	if (!dev_priv->dp_phy_comp) {
 	if (ret) {

-:97: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#97: FILE: drivers/gpu/drm/i915/display/intel_display.c:15529:
+	if (!dev_priv->dp_phy_comp) {
 	i915_sw_fence_commit(&state->commit_ready);

-:97: WARNING:BRACES: braces {} are not necessary for single statement blocks
#97: FILE: drivers/gpu/drm/i915/display/intel_display.c:15529:
+	if (!dev_priv->dp_phy_comp) {
 	i915_sw_fence_commit(&state->commit_ready);
+	}

total: 1 errors, 5 warnings, 0 checks, 181 lines checked



More information about the Intel-gfx mailing list