[Intel-gfx] [PATCH] snd/hda, drm/i915: Track the display_power_status using a cookie

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 13 21:52:25 UTC 2019


Quoting Takashi Iwai (2019-02-13 21:48:50)
> On Wed, 13 Feb 2019 16:21:09 +0100,
> Chris Wilson wrote:
> > 
> > drm/i915 is tracking all wakeref owners with a cookie in order to
> > identify leaks. To that end, each rpm acquisition ops->get_power is
> > assigned a cookie which should be passed to ops->put_power to signify
> > its release (and removal from the list of wakeref owners). As snd/hda is
> > already using a bool to track current status of display_power extending
> > that to an unsigned long to hold the boolean cookie is a trivial
> > extension, and will quell all doubt that snd/hda is the cause of the
> > device runtime pm leaks.
> > 
> > v2: Keep using the power abstraction for local wakeref tracking.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Takashi Iwai <tiwai at suse.de>
> > Cc: Jani Nikula <jani.nikula at intel.com>
> 
> Feel free to take my ack:
>   Reviewed-by: Takashi Iwai <tiwai at suse.de>
> 
> Or let me know if you guys want to apply this through sound tree for
> 5.1 merge.

It's a debug featurette so it's not urgent in any way; it's just for
identifying bugs in CI. I think we're good to go in through
drm-intel-next-queued for 5.2
-Chris


More information about the Intel-gfx mailing list