[Intel-gfx] [RFC PATCH 20/42] drm/i915/lmem: support pread

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 14 15:50:55 UTC 2019


Quoting Matthew Auld (2019-02-14 14:57:18)
> +       ret = mutex_lock_interruptible(&i915->drm.struct_mutex);
> +       if (ret)
> +               goto out_unpin;
> +
> +       wakeref = intel_runtime_pm_get(i915);

But why wakeref in the middle?
> +
> +       ret = i915_gem_object_set_to_wc_domain(obj, false);
> +       mutex_unlock(&i915->drm.struct_mutex);

Anyway, this is a disaster that needs fixing before we make it worse.
-Chris


More information about the Intel-gfx mailing list