[Intel-gfx] [PATCH v2] drm/i915: Beware temporary wedging when determining -EIO

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Feb 19 13:47:33 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Chris Wilson (2019-02-19 13:38:55)
>> diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c
>> index 4df4c674223d..3c74b828f5be 100644
>> --- a/drivers/gpu/drm/i915/i915_reset.c
>> +++ b/drivers/gpu/drm/i915/i915_reset.c
>> @@ -1334,6 +1334,21 @@ __releases(&i915->gpu_error.reset_backoff_srcu)
>>         srcu_read_unlock(&error->reset_backoff_srcu, tag);
>>  }
>>  
>> +int i915_reset_backoff(struct drm_i915_private *i915)
>
> Now this is just returning -EIO, we should rethink its name.
>
> Maybe this should be the i915_terminally_wedged() and the existing
> inline __i915_terminally_wedged(). Though less on the terminally part!

Oh yes please. Lets rethink the terminology and fix it up starting
all the way up from debugs entrypoints =)

-Mika


More information about the Intel-gfx mailing list