[Intel-gfx] [PATCH] drm/i915/hdcp: Silence compiler critics

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 21 14:04:53 UTC 2019


Quoting Ville Syrjälä (2019-02-21 13:52:07)
> On Thu, Feb 21, 2019 at 08:48:33AM +0000, Chris Wilson wrote:
> > drivers/gpu/drm/i915/intel_hdcp.c:92 intel_hdcp2_capable() warn: inconsistent indenting
> > drivers/gpu/drm/i915/intel_hdcp.c:786:5: error: no previous prototype for ‘intel_hdcp_check_link’
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> >  drivers/gpu/drm/i915/intel_hdcp.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> > index 6178fe93f398..9ce09f67776d 100644
> > --- a/drivers/gpu/drm/i915/intel_hdcp.c
> > +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> > @@ -89,10 +89,10 @@ static bool intel_hdcp2_capable(struct intel_connector *connector)
> >  
> >       /* MEI interface is solid */
> >       mutex_lock(&dev_priv->hdcp_comp_mutex);
> > -             if (!dev_priv->hdcp_comp_added ||  !dev_priv->hdcp_master) {
> > -                     mutex_unlock(&dev_priv->hdcp_comp_mutex);
> > -                     return false;
> > -             }
> > +     if (!dev_priv->hdcp_comp_added ||  !dev_priv->hdcp_master) {
>                                          ^^
> 
> That too looks a bit funky.

s/  / ​/

* wonders how that renders
-Chris


More information about the Intel-gfx mailing list