[Intel-gfx] [PATCH] drm/i915/guc: Flush the residual log capture after disabling
Chris Wilson
chris at chris-wilson.co.uk
Thu Feb 21 16:33:41 UTC 2019
Quoting Mika Kuoppala (2019-02-21 16:24:06)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
>
> > After we have marked the log capture as disabled, then flush the log
> > capture worker so that it will not re-queue itself.
>
> It is not the worker that re-queues so remove the re-queue part.
Yeah, we are definitely missing a synchronize_irq() after
guc_log_disable_flush_events() as well.
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
Care to keep the r-b with
> > @@ -621,13 +621,14 @@ void intel_guc_log_relay_flush(struct intel_guc_log *log)
> > void intel_guc_log_relay_close(struct intel_guc_log *log)
> > {
> > guc_log_disable_flush_events(log);
+ synchronize_irq(i915->drm.irq);
?
-Chris
More information about the Intel-gfx
mailing list