[Intel-gfx] [PATCH 2/3] drm/i915: introduce platform_flags to use with dpll hooks

Lucas De Marchi lucas.demarchi at intel.com
Fri Feb 22 23:23:23 UTC 2019


Define platform flags taking the high 16 bits of the under-utilized
flags in dpll_info. This makes clear separation on what flags are used
by the core and what flags can be freely defined for use in the context
of the platforms sharing a set of hooks.

The initial motivation for this is the Ice Lake case that heavily relies
on the PLL id to make decisions on what type of PLL that is. This
hinders code sharing across platforms as the IDs may change easily.

Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
 drivers/gpu/drm/i915/intel_dpll_mgr.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.h b/drivers/gpu/drm/i915/intel_dpll_mgr.h
index 40e8391a92f2..b1fdce1be942 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.h
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.h
@@ -279,7 +279,14 @@ struct dpll_info {
 	 *     Inform the state checker that the DPLL is kept enabled even if
 	 *     not in use by any CRTC.
 	 */
-	u32 flags;
+	u16 flags;
+
+	/**
+	 * @platform_flags: like @flags, but these make are meant to use
+	 * within a single platform scope only (or just a few, when the hooks
+	 * are shared)
+	 */
+	u16 platform_flags;
 };
 
 /**
-- 
2.20.0



More information about the Intel-gfx mailing list