[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Make request allocation caches global (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Feb 28 09:00:15 UTC 2019


== Series Details ==

Series: series starting with [1/3] drm/i915: Make request allocation caches global (rev2)
URL   : https://patchwork.freedesktop.org/series/57319/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8a14917577db drm/i915: Make request allocation caches global
-:163: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#163: 
new file mode 100644

-:168: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#168: FILE: drivers/gpu/drm/i915/i915_globals.c:1:
+/*

-:287: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#287: FILE: drivers/gpu/drm/i915/i915_globals.h:1:
+/*

-:628: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#628: FILE: drivers/gpu/drm/i915/i915_scheduler.h:93:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:628: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#628: FILE: drivers/gpu/drm/i915/i915_scheduler.h:93:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:632: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#632: FILE: drivers/gpu/drm/i915/i915_scheduler.h:97:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

-:632: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#632: FILE: drivers/gpu/drm/i915/i915_scheduler.h:97:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

total: 0 errors, 3 warnings, 4 checks, 800 lines checked
c7f4192bde9d drm/i915: Make object/vma allocation caches global
da8c64327422 drm/i915: Remove second level open-coded rcu work



More information about the Intel-gfx mailing list