[Intel-gfx] [igt-dev] [PATCH i-g-t 5/5] tests/i915/pm_rc6_residency: Fix linking

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 28 14:33:06 UTC 2019


Quoting Tvrtko Ursulin (2019-02-28 14:18:28)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Probably a leftover from test renames:
> 
>   tests/Makefile.am:134: warning: variable 'pm_rc6_residency_LDADD' is defined but no program or
>   tests/Makefile.am:134: library has 'pm_rc6_residency' as canonical name (possible typo)
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>  tests/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index c5dd210c7163..80bc5f92a13b 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -131,7 +131,7 @@ perf_pmu_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
>  gem_eio_LDADD = $(LDADD) -lrt
>  gem_wait_LDADD = $(LDADD) -lrt
>  kms_flip_LDADD = $(LDADD) -lrt -lpthread
> -pm_rc6_residency_LDADD = $(LDADD) -lrt
> +i915_pm_rc6_residency_LDADD = $(LDADD) -lrt

Have we not snuck -lrt into the core library yet, pretty sure libigt.la
now includes clock_gettime() and so must be pulling it in already?

i.e. can we just drop the above line?
-Chris


More information about the Intel-gfx mailing list