[Intel-gfx] [PATCH 02/39] drm/i915/selftests: Take a breath during check_partial_mappings()

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed Jan 2 11:07:31 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> With kasan on a slow machine, it can take an age to check all the
> partial mappings in a single iteration, so break it up with a
> cond_resched) to avoid RCU stall reports.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/selftests/i915_gem_object.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_object.c b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
> index c3999dd2021e..be7ecb66ad11 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
> @@ -238,6 +238,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,
>  		u32 *cpu;
>  
>  		GEM_BUG_ON(view.partial.size > nreal);
> +		cond_resched();

Didn't get all the intricacies of rcu, but looks of it
this marks up the need of urgent quiescent state, even
if there is nothing to reschedule so should help for stall
reports.

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>


>  
>  		err = i915_gem_object_set_to_gtt_domain(obj, true);
>  		if (err) {
> -- 
> 2.20.1


More information about the Intel-gfx mailing list