[Intel-gfx] [PATCH 24/39] drm/i915: Stop tracking MRU activity on VMA

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 2 13:48:58 UTC 2019


Quoting Tvrtko Ursulin (2019-01-02 13:13:23)
> 
> On 02/01/2019 09:41, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
> > index a0039ea97cdc..bd679c8c56dd 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.h
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
> > @@ -299,32 +299,12 @@ struct i915_address_space {
> >       struct i915_page_directory_pointer *scratch_pdp; /* GEN8+ & 48b PPGTT */
> >   
> >       /**
> > -      * List of objects currently involved in rendering.
> > -      *
> > -      * Includes buffers having the contents of their GPU caches
> > -      * flushed, not necessarily primitives. last_read_req
> > -      * represents when the rendering involved will be completed.
> > -      *
> > -      * A reference is held on the buffer while on this list.
> > +      * List of vma currently bound.
> 
> Reference held comment can stay I hope.

No, that's talking about the active reference, which is only implied and
not technically true even today :)
-Chris


More information about the Intel-gfx mailing list