[Intel-gfx] [PATCH] drm/i915/ringbuffer: Drop gen7_xcs_emit_breadcrumb

Fri Jan 4 11:20:03 UTC 2019

Quoting Mika Kuoppala (2019-01-04 09:36:05)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > The additional flushes for gen7 appear to have been a red herring as the
> > more efficacious workaround seems to be commit 476af9c26063 ("drm/i915/gen6:
> > Flush RING_IMR changes before changing the global GT IMR"). Trusting the
> > updated results means we can remove the special casing for gen7_xcs and
> > reduce it to the gen6_xcs_emit_breadcrumb.
> >
> > References: 476af9c26063 ("drm/i915/gen6: Flush RING_IMR changes before changing the global GT IMR")
> > Fixes: 1212bd821de8 ("drm/i915/ringbuffer: Move irq seqno barrier to the GPU for gen7")
> > Testcase: igt/gem_sync
> 
> This would be nice simplification but gem_sync failed on hsw. I tried to
> look at the details but the web page on shards says it has not run yet (?)

Confidence is high that's it just an aberration. Completed a clean run
on ivb, byt and now hsw (i5-4210H, gt1):

./intel-gpu-tools/tests/gem_sync
IGT-Version: 1.22-gb82dbb2 (x86_64) (Linux: 4.20.0+ x86_64)
Using Legacy submission
Completed 33717248 cycles: 4.449 us
Subtest default: SUCCESS (150.011s)
Completed 1645568 cycles: 91.193 us
Subtest idle-default: SUCCESS (150.064s)
Completed 1778688 cycles: 84.360 us
Subtest store-default: SUCCESS (150.084s)
Completed 32429 cycles
Subtest many-default: SUCCESS (161.083s)
Completed 8797184 cycles: 17.051 us
Completed 10115072 cycles: 14.830 us
Completed 9020416 cycles: 16.630 us
Completed 8855552 cycles: 16.940 us
Subtest forked-default: SUCCESS (150.023s)
Completed 541696 cycles: 277.192 us
Completed 541696 cycles: 277.193 us
Completed 541696 cycles: 277.193 us
Completed 541696 cycles: 277.194 us
Subtest forked-store-default: SUCCESS (150.171s)
Completed 33402880 cycles: 4.491 us
Subtest render: SUCCESS (150.018s)
Completed 1648640 cycles: 90.988 us
Subtest idle-render: SUCCESS (150.007s)
Completed 1753088 cycles: 85.574 us
Subtest store-render: SUCCESS (150.060s)
Completed 32424 cycles
Subtest many-render: SUCCESS (161.089s)
Completed 6104064 cycles: 24.574 us
Completed 10889216 cycles: 13.776 us
Completed 10352640 cycles: 14.490 us
Completed 9607168 cycles: 15.615 us
Subtest forked-render: SUCCESS (150.029s)
Completed 541696 cycles: 277.036 us
Completed 541696 cycles: 277.042 us
Completed 541696 cycles: 277.041 us
Completed 541696 cycles: 277.041 us
Subtest forked-store-render: SUCCESS (150.092s)
Completed 54293504 cycles: 2.763 us
Subtest bsd: SUCCESS (150.015s)
Completed 3308544 cycles: 45.346 us
Subtest idle-bsd: SUCCESS (150.028s)
Completed 1852416 cycles: 81.008 us
Subtest store-bsd: SUCCESS (150.090s)
Completed 33210 cycles
Subtest many-bsd: SUCCESS (161.081s)
Completed 19262464 cycles: 7.787 us
Completed 19212288 cycles: 7.808 us
Completed 19230720 cycles: 7.800 us
Completed 19190784 cycles: 7.816 us
Subtest forked-bsd: SUCCESS (150.010s)
Completed 556032 cycles: 269.790 us
Completed 556032 cycles: 269.791 us
Completed 556032 cycles: 269.791 us
Completed 556032 cycles: 269.792 us
Subtest forked-store-bsd: SUCCESS (150.027s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest bsd1: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest idle-bsd1: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest store-bsd1: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest many-bsd1: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest forked-bsd1: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest forked-store-bsd1: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest bsd2: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest idle-bsd2: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest store-bsd2: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest many-bsd2: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest forked-bsd2: SKIP (0.000s)
Test requirement not met in function gem_require_ring, file ioctl_wrappers.c:1493:
Test requirement: gem_has_ring(fd, ring)
Subtest forked-store-bsd2: SKIP (0.000s)
Completed 53180416 cycles: 2.821 us
Subtest blt: SUCCESS (150.013s)
Completed 3321856 cycles: 45.164 us
Subtest idle-blt: SUCCESS (150.027s)
Completed 1836032 cycles: 81.728 us
Subtest store-blt: SUCCESS (150.075s)
Completed 33173 cycles
Subtest many-blt: SUCCESS (161.084s)
Completed 19266560 cycles: 7.786 us
Completed 19283968 cycles: 7.779 us
Completed 19229696 cycles: 7.801 us
Completed 19256320 cycles: 7.790 us
Subtest forked-blt: SUCCESS (150.021s)
Completed 556032 cycles: 269.802 us
Completed 556032 cycles: 269.807 us
Completed 556032 cycles: 269.807 us
Completed 556032 cycles: 269.807 us
Subtest forked-store-blt: SUCCESS (150.036s)
Completed 45681664 cycles: 3.284 us
Subtest vebox: SUCCESS (150.007s)
Completed 3311616 cycles: 45.298 us
Subtest idle-vebox: SUCCESS (150.011s)
Completed 1793024 cycles: 83.704 us
Subtest store-vebox: SUCCESS (150.122s)
Completed 33118 cycles
Subtest many-vebox: SUCCESS (161.090s)
Completed 19568640 cycles: 7.665 us
Completed 19570688 cycles: 7.665 us
Completed 19557376 cycles: 7.670 us
Completed 19578880 cycles: 7.662 us
Subtest forked-vebox: SUCCESS (150.024s)
Completed 556032 cycles: 269.848 us
Completed 556032 cycles: 269.848 us
Completed 556032 cycles: 269.853 us
Completed 556032 cycles: 269.853 us
Subtest forked-store-vebox: SUCCESS (150.055s)
blt completed 930816 cycles: 5.372 us
render completed 708608 cycles: 7.060 us
bsd completed 933888 cycles: 5.358 us
vebox completed 932864 cycles: 5.364 us
Subtest basic-each: SUCCESS (5.016s)
render completed 17408 cycles: 289.600 us
vebox completed 18432 cycles: 274.692 us
bsd completed 19456 cycles: 264.808 us
blt completed 19456 cycles: 264.834 us
Subtest basic-store-each: SUCCESS (5.169s)
render completed 286 cycles
bsd completed 288 cycles
blt completed 289 cycles
vebox completed 290 cycles
Subtest basic-many-each: SUCCESS (5.416s)
bsd completed 5719040 cycles: 26.228 us
blt completed 5732352 cycles: 26.169 us
render completed 3632128 cycles: 41.301 us
blt completed 5811200 cycles: 25.812 us
blt completed 5753856 cycles: 26.070 us
vebox completed 5685248 cycles: 26.386 us
bsd completed 5786624 cycles: 25.923 us
vebox completed 5888000 cycles: 25.476 us
render completed 3789824 cycles: 39.583 us
render completed 3788800 cycles: 39.591 us
bsd completed 5816320 cycles: 25.792 us
vebox completed 5878784 cycles: 25.519 us
vebox completed 5705728 cycles: 26.292 us
bsd completed 5828608 cycles: 25.735 us
render completed 3735552 cycles: 40.159 us
blt completed 5726208 cycles: 26.196 us
Subtest forked-each: SUCCESS (150.043s)
vebox completed 138240 cycles: 1085.218 us
vebox completed 138240 cycles: 1085.242 us
vebox completed 138240 cycles: 1085.240 us
vebox completed 138240 cycles: 1085.238 us
render completed 137216 cycles: 1097.126 us
render completed 137216 cycles: 1097.129 us
render completed 137216 cycles: 1097.122 us
render completed 137216 cycles: 1097.130 us
blt completed 141312 cycles: 1066.105 us
blt completed 141312 cycles: 1066.106 us
blt completed 141312 cycles: 1066.105 us
blt completed 141312 cycles: 1066.100 us
bsd completed 141312 cycles: 1066.161 us
bsd completed 141312 cycles: 1066.166 us
bsd completed 141312 cycles: 1066.157 us
bsd completed 141312 cycles: 1066.155 us
Subtest forked-store-each: SUCCESS (150.679s)
Completed 778240 cycles: 6.427 us
Subtest basic-all: SUCCESS (5.020s)
Completed 15360 cycles: 328.319 us
Subtest basic-store-all: SUCCESS (5.060s)
Completed 20385792 cycles: 7.358 us
Subtest all: SUCCESS (150.025s)
Completed 472064 cycles: 317.875 us
Subtest store-all: SUCCESS (150.076s)
Completed 4675584 cycles: 32.082 us
Completed 4675584 cycles: 32.084 us
Completed 4674560 cycles: 32.092 us
Completed 4676608 cycles: 32.078 us
Subtest forked-all: SUCCESS (150.035s)
Completed 135168 cycles: 1114.149 us
Completed 135168 cycles: 1114.155 us
Completed 135168 cycles: 1114.161 us
Completed 135168 cycles: 1114.163 us
Subtest forked-store-all: SUCCESS (150.609s)
Test requirement not met in function __real_main743, file gem_sync.c:803:
Test requirement: gem_scheduler_has_ctx_priority(fd)
Subtest preempt-all: SKIP
Subtest preempt-default: SKIP
Subtest preempt-render: SKIP
Subtest preempt-bsd: SKIP
Subtest preempt-bsd1: SKIP
Subtest preempt-bsd2: SKIP
Subtest preempt-blt: SKIP
Subtest preempt-vebox: SKIP
-Chris