[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev4)

[Patchwork]

== Series Details ==

Series: MST refcounting/atomic helpers cleanup (rev4)
URL   : https://patchwork.freedesktop.org/series/54030/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2a2093f380b0 drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends
-:84: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:990:
+			rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1006:
+		rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:150: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#150: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1373:
+			mstb_child = drm_dp_mst_topology_get_mstb_validated(

total: 0 errors, 0 warnings, 3 checks, 399 lines checked
395ddef17891 drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
commit 263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")

-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51: 
commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")

-:136: WARNING:BAD_SIGN_OFF: Duplicate signature
#136: 
Signed-off-by: Lyude Paul <lyude at redhat.com>

-:139: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#139: 
new file mode 100644

-:844: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#844: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1329:
+			mport = drm_dp_mst_topology_get_port_validated_locked(

-:858: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#858: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1346:
+		rport = drm_dp_mst_topology_get_port_validated_locked(

total: 1 errors, 3 warnings, 2 checks, 975 lines checked
a20c087d93b3 drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails
42483b36cce0 drm/dp_mst: Stop releasing VCPI when removing ports from topology
922a91cd84d2 drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2276:
+				port = drm_dp_mst_topology_get_port_validated(

total: 0 errors, 0 warnings, 1 checks, 124 lines checked
c9b9ef293e41 drm/i915: Keep malloc references to MST ports
5dbb33b4a196 drm/amdgpu/display: Keep malloc ref to MST port
90a9631dfbe1 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
03cee9c12c05 drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
0d5dc5d62fd6 drm/nouveau: Keep malloc references to MST ports
81af58e1850c drm/nouveau: Stop unsetting mstc->port, use malloc refs
b6f6bbe3d1bc drm/nouveau: Grab payload lock in nv50_msto_payload()
42197be73f27 drm/dp_mst: Add some atomic state iterator macros
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:112: WARNING:LONG_LINE: line over 100 characters
#112: FILE: include/drm/drm_dp_mst_helper.h:712:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/drm/drm_dp_mst_helper.h:729:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: include/drm/drm_dp_mst_helper.h:747:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

total: 0 errors, 3 warnings, 6 checks, 120 lines checked
31f003c7f24b drm/dp_mst: Start tracking per-port VCPI allocations
-:42: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#42: 
* Add some missing changes that were requested by danvet that I forgot about after

total: 0 errors, 1 warnings, 0 checks, 444 lines checked
7e8e5b7e31ad drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
b2223e97312f drm/nouveau: Use atomic VCPI helpers for MST