[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

Patchwork patchwork at emeril.freedesktop.org
Mon Jan 7 12:45:39 UTC 2019 

== Series Details ==

Series: series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim
URL   : https://patchwork.freedesktop.org/series/54803/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7b61c9e7b9d7 drm/i915: Return immediately if trylock fails for direct-reclaim
-:54: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#54: FILE: drivers/gpu/drm/i915/i915_drv.h:3191:
+				    struct mutex *mutex);

total: 0 errors, 0 warnings, 1 checks, 172 lines checked
15f754232c8b drm/i915: Report the number of closed vma held by each context in debugfs
-:68: WARNING:LONG_LINE: line over 100 characters
#68: FILE: drivers/gpu/drm/i915/i915_debugfs.c:348:
+		seq_printf(m, "%s: %lu objects, %llu bytes (%llu active, %llu inactive, %llu global, %llu shared, %llu unbound, %llu closed)\n", \

total: 0 errors, 1 warnings, 0 checks, 201 lines checked
44eb22b9d0e9 drm/i915: Track all held rpm wakerefs
-:106: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#106: FILE: drivers/gpu/drm/i915/i915_drv.h:1162:
+	spinlock_t debug_lock;

total: 0 errors, 0 warnings, 1 checks, 571 lines checked
4474d8b3116c drm/i915: Markup paired operations on wakerefs
-:380: WARNING:NEW_TYPEDEFS: do not add new typedefs
#380: FILE: drivers/gpu/drm/i915/i915_drv.h:134:
+typedef depot_stack_handle_t intel_wakeref_t;

total: 0 errors, 1 warnings, 0 checks, 1168 lines checked
73bb87c62275 drm/i915: Track GT wakeref
ecc94ab152f0 drm/i915: Track the rpm wakerefs for error handling
51f4dc876674 drm/i915: Mark up sysfs with rpm wakeref tracking
bbadf9c61168 drm/i915: Mark up debugfs with rpm wakeref tracking
6f69f6cb282d drm/i915/perf: Track the rpm wakeref
4a6ad9c0bf6b drm/i915/pmu: Track rpm wakeref
27ac441fad2c drm/i915/guc: Track the rpm wakeref
31d63b175d79 drm/i915/gem: Track the rpm wakerefs
a92f6a6c3356 drm/i915/fb: Track rpm wakerefs
8cc18f52ef6e drm/i915/hotplug: Track temporary rpm wakeref
bb14613eca20 drm/i915/panel: Track temporary rpm wakeref
597c006df1dc drm/i915/selftests: Mark up rpm wakerefs
6f2468caa207 drm/i915: Syntatic sugar for using intel_runtime_pm
-:512: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#512: FILE: drivers/gpu/drm/i915/intel_drv.h:2190:
+#define with_intel_runtime_pm(i915, wf) \
+	for (wf = intel_runtime_pm_get(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

-:512: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#512: FILE: drivers/gpu/drm/i915/intel_drv.h:2190:
+#define with_intel_runtime_pm(i915, wf) \
+	for (wf = intel_runtime_pm_get(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#516: FILE: drivers/gpu/drm/i915/intel_drv.h:2194:
+#define with_intel_runtime_pm_if_in_use(i915, wf) \
+	for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#516: FILE: drivers/gpu/drm/i915/intel_drv.h:2194:
+#define with_intel_runtime_pm_if_in_use(i915, wf) \
+	for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \
+	     intel_runtime_pm_put(i915, wf), wf = 0)

total: 0 errors, 0 warnings, 4 checks, 734 lines checked
b80423487b07 drm/i915: Markup paired operations on display power domains
e1b960f8dd38 drm/i915: Track the wakeref used to initialise display power domains
-:214: WARNING:LINE_SPACING: Missing a blank line after declarations
#214: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:4107:
+	struct i915_power_domains *power_domains = &i915->power_domains;
+	intel_wakeref_t wakeref __maybe_unused =

total: 0 errors, 1 warnings, 0 checks, 324 lines checked
3ca33907833e drm/i915: Combined gt.awake/gt.power wakerefs
2846424a5065 drm/i915/dp: Markup pps lock power well
-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dp' - possible side-effects?
#58: FILE: drivers/gpu/drm/i915/intel_dp.c:635:
+#define with_pps_lock(dp, wf) \
+	for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf))

-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#58: FILE: drivers/gpu/drm/i915/intel_dp.c:635:
+#define with_pps_lock(dp, wf) \
+	for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf))

total: 0 errors, 0 warnings, 2 checks, 430 lines checked
2cf475a0e278 drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice
439540e3f554 drm/i915: Mark up Ironlake ips with rpm wakerefs
6888a1eda106 drm/i915: Serialise concurrent calls to i915_gem_set_wedged()
-:48: WARNING:MEMORY_BARRIER: memory barrier without comment
#48: FILE: drivers/gpu/drm/i915/i915_gem.c:3230:
+	smp_mb__before_atomic();

total: 0 errors, 1 warnings, 0 checks, 110 lines checked
c9872aff5d50 drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex
015a2f8dbceb drm/i915: Pull all the reset functionality together into i915_reset.c
-:1089: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1089: 
new file mode 100644

-:1094: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1094: FILE: drivers/gpu/drm/i915/i915_reset.c:1:
+/*

-:1238: WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?
#1238: FILE: drivers/gpu/drm/i915/i915_reset.c:145:
+	/* Assert reset for at least 20 usec, and wait for acknowledgement. */

-:1963: WARNING:MEMORY_BARRIER: memory barrier without comment
#1963: FILE: drivers/gpu/drm/i915/i915_reset.c:870:
+	smp_mb__before_atomic();

-:2262: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2262: FILE: drivers/gpu/drm/i915/i915_reset.c:1169:
+	char *error_event[] = { I915_ERROR_UEVENT "=1", NULL };

-:2263: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2263: FILE: drivers/gpu/drm/i915/i915_reset.c:1170:
+	char *reset_event[] = { I915_RESET_UEVENT "=1", NULL };

-:2264: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2264: FILE: drivers/gpu/drm/i915/i915_reset.c:1171:
+	char *reset_done_event[] = { I915_ERROR_UEVENT "=0", NULL };

-:2489: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2489: FILE: drivers/gpu/drm/i915/i915_reset.h:1:
+/*

-:2539: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects?
#2539: FILE: drivers/gpu/drm/i915/i915_reset.h:51:
+#define i915_wedge_on_timeout(W, DEV, TIMEOUT)				\
+	for (__i915_init_wedge((W), (DEV), (TIMEOUT), __func__);	\
+	     (W)->i915;							\
+	     __i915_fini_wedge((W)))

total: 0 errors, 8 warnings, 1 checks, 3113 lines checked
0129900c3794 drm/i915: Make all GPU resets atomic
-:23: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#23: FILE: drivers/gpu/drm/i915/i915_reset.c:147:
+	udelay(50);

-:29: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#29: FILE: drivers/gpu/drm/i915/i915_reset.c:152:
+	udelay(50);

total: 0 errors, 0 warnings, 2 checks, 121 lines checked
d9c35bdc837f drm/i915/guc: Disable global reset
5872f352bbf4 drm/i915: Remove GPU reset dependence on struct_mutex
-:616: WARNING:MEMORY_BARRIER: memory barrier without comment
#616: FILE: drivers/gpu/drm/i915/i915_reset.c:692:
+	smp_store_mb(i915->gpu_error.restart, NULL);

-:769: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#769: FILE: drivers/gpu/drm/i915/i915_reset.c:920:
+#if 0

total: 0 errors, 2 warnings, 0 checks, 1395 lines checked
5c6544073058 drm/i915: Issue engine resets onto idle engines
850cfae97d02 drm/i915: Stop tracking MRU activity on VMA
05f0e0d4f8c8 drm/i915: Pull VM lists under the VM mutex.
aaf60bafd95e drm/i915: Move vma lookup to its own lock
-:157: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t
#157: FILE: drivers/gpu/drm/i915/i915_gem_object.h:92:
+		struct spinlock lock;

total: 0 errors, 1 warnings, 0 checks, 284 lines checked
d7ed47a26a28 drm/i915: Move intel_execlists_show_requests() aside
710f39b1dd59 drm/i915: Use b->irq_enable() as predicate for mock engine
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling")'
#6: 
Since commit  d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling")

-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling")'
#10: 
References: d4ccceb05591 ("drm/i915/icl: Ringbuffer interrupt handling")

total: 2 errors, 0 warnings, 0 checks, 111 lines checked
f100df244053 drm/i915/selftests: Allocate mock ring/timeline per context
898cc7add579 drm/i915/selftests: Make evict tolerant of foreign objects
bcbacd09560a drm/i915: Remove the intel_engine_notify tracepoint
7addb9fa85ee drm/i915: Always allocate an object/vma for the HWSP
7eaf41844056 drm/i915: Move list of timelines under its own lock
-:20: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:1961:
+		struct mutex timeline_lock;

total: 0 errors, 0 warnings, 1 checks, 314 lines checked
82cb670aee32 drm/i915: Introduce concept of per-timeline (context) HWSP
b74a0ab29880 drm/i915: Enlarge vma->pin_count
3a18270b30aa drm/i915: Allocate a status page for each timeline
caa054848443 drm/i915: Track the context's seqno in its own timeline HWSP
-:176: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#176: FILE: drivers/gpu/drm/i915/intel_lrc.c:2043:
 }
+static const int gen8_emit_breadcrumb_sz = 10 + WA_TAIL_DWORDS;

-:207: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#207: FILE: drivers/gpu/drm/i915/intel_lrc.c:2069:
 }
+static const int gen8_emit_breadcrumb_rcs_sz = 14 + WA_TAIL_DWORDS;

-:233: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#233: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:344:
 }
+static const int gen6_rcs_emit_breadcrumb_sz = 18;

-:256: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#256: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:451:
 }
+static const int gen7_rcs_emit_breadcrumb_sz = 10;

-:277: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#277: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:469:
 }
+static const int gen6_xcs_emit_breadcrumb_sz = 8;

-:305: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#305: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:499:
 }
+static const int gen7_xcs_emit_breadcrumb_sz = 10 + GEN7_XCS_WA * 3;

-:357: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#357: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:945:
 }
+static const int i9xx_emit_breadcrumb_sz = 8;

-:385: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#385: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:973:
 }
+static const int gen5_emit_breadcrumb_sz = GEN5_WA_STORES * 3 + 6;

total: 0 errors, 0 warnings, 8 checks, 402 lines checked
494f87700216 drm/i915: Identify active requests
-:67: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#67: FILE: drivers/gpu/drm/i915/i915_timeline.h:50:
+	bool has_initial_breadcrumb;

total: 0 errors, 0 warnings, 1 checks, 88 lines checked
0bf3389593c0 drm/i915: Replace global breadcrumbs with per-context interrupt tracking
-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")'
#18: 
Before commit 688e6c725816, the solution was simple. Every client waking

-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")'
#21: 
688e6c725816 introduced an rbtree so that only the earliest waiter on

-:49: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#49: 
References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")

-:49: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")'
#49: 
References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")

-:1868: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1868: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:395:
+		bool irq_armed;

-:1869: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1869: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:396:
+		bool irq_fired;

-:2009: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct i915_gem_context *' should also have an identifier name
#2009: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:257:
+	struct i915_request *(*request_alloc)(struct i915_gem_context *,

-:2009: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_engine_cs *' should also have an identifier name
#2009: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:257:
+	struct i915_request *(*request_alloc)(struct i915_gem_context *,

-:2033: WARNING:LINE_SPACING: Missing a blank line after declarations
#2033: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:281:
+	struct i915_request **requests;
+	I915_RND_STATE(prng);

-:2440: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#2440: 
deleted file mode 100644

total: 3 errors, 5 warnings, 2 checks, 2425 lines checked

More information about the Intel-gfx mailing list