[Intel-gfx] [v4 05/12] drm: Add HDR capability field to plane structure

[Shankar, Uma]

>-----Original Message-----
>From: Liviu Dudau [mailto:liviu at dudau.co.uk]
>Sent: Thursday, January 10, 2019 4:17 PM
>To: Shankar, Uma <uma.shankar at intel.com>
>Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; Syrjala, Ville
><ville.syrjala at intel.com>; emil.l.velikov at gmail.com; Lankhorst, Maarten
><maarten.lankhorst at intel.com>
>Subject: Re: [v4 05/12] drm: Add HDR capability field to plane structure
>
>Hi Uma,
>
>On Tue, Jan 08, 2019 at 02:41:20PM +0530, Uma Shankar wrote:
>> Hardware may have HDR capability on certain plane engines. Enabling
>> the same in drm plane structure so that this can be communicated to
>> user space.
>>
>> Each drm driver should set this flag to true for planes which support
>> HDR.
>>
>> v2: Rebase
>>
>> Signed-off-by: Uma Shankar <uma.shankar at intel.com>
>> ---
>>  include/drm/drm_plane.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index
>> 6078c70..206eefc 100644
>> --- a/include/drm/drm_plane.h
>> +++ b/include/drm/drm_plane.h
>> @@ -638,6 +638,9 @@ struct drm_plane {
>>  	/** @type: Type of plane, see &enum drm_plane_type for details. */
>>  	enum drm_plane_type type;
>>
>> +	/* Value of true:1 means HDR is supported */
>> +	bool hdr_supported;
>> +
>
>I don't see where this is used, am I missing something? You attach the property to
>the connector, I don't see how the planes get involved in the end.

Hi Liviu,
Yes currently it's not linked to plane, but I am planning to add a property interface which tells
userspace what underlying hardware planes are capable of HDR. For now, this is not used and
I can drop it to avoid any confusion. Will be sending out the plane capability property for HDR
pretty soon (most probably along with next version of this series).

Regards,
Uma Shankar

>Best regards,
>Liviu
>
>
>>  	/**
>>  	 * @index: Position inside the mode_config.list, can be used as an array
>>  	 * index. It is invariant over the lifetime of the plane.
>> --
>> 1.9.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>--
>           ________________________________________________________
>  ________|                                                        |_______
>  \       |  With enough courage, you can do without a reputation  |      /
>   \      |                                  -- Rhett Butler       |     /
>   /      |________________________________________________________|     \
>  /__________)                                                  (_________\