[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/cnl: Fix CNL macros for Voltage Swing programming (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Jan 11 00:25:56 UTC 2019


== Series Details ==

Series: drm/i915/cnl: Fix CNL macros for Voltage Swing programming (rev2)
URL   : https://patchwork.freedesktop.org/series/54092/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8b810fada4b5 drm/i915/cnl: Fix CNL macros for Voltage Swing programming
-:26: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#26: FILE: drivers/gpu/drm/i915/i915_reg.h:1817:
+#define _CNL_PORT_TX_DW_GRP(dw, port)	(_PICK((port), \
 					       _CNL_PORT_TX_AE_GRP_OFFSET, \
 					       _CNL_PORT_TX_B_GRP_OFFSET, \
 					       _CNL_PORT_TX_B_GRP_OFFSET, \

-:35: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#35: FILE: drivers/gpu/drm/i915/i915_reg.h:1825:
+#define _CNL_PORT_TX_DW_LN0(dw, port)	(_PICK((port), \
 					       _CNL_PORT_TX_AE_LN0_OFFSET, \
 					       _CNL_PORT_TX_B_LN0_OFFSET, \
 					       _CNL_PORT_TX_B_LN0_OFFSET, \

total: 2 errors, 0 warnings, 0 checks, 38 lines checked



More information about the Intel-gfx mailing list