[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/audio: Track temporary rpm wakerefs

Patchwork patchwork at emeril.freedesktop.org
Mon Jan 14 18:21:33 UTC 2019


== Series Details ==

Series: series starting with [1/3] drm/i915/audio: Track temporary rpm wakerefs
URL   : https://patchwork.freedesktop.org/series/55194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b531f8b4dca8 drm/i915/audio: Track temporary rpm wakerefs
c78a3bd63af7 snd/hda: Track the display_power_status using a cookie
-:57: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#57: FILE: include/drm/drm_audio_component.h:25:
+	unsigned long (*get_power)(struct device *);

-:64: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#64: FILE: include/drm/drm_audio_component.h:31:
+	void (*put_power)(struct device *, unsigned long);

-:64: WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned long' should also have an identifier name
#64: FILE: include/drm/drm_audio_component.h:31:
+	void (*put_power)(struct device *, unsigned long);

total: 0 errors, 3 warnings, 0 checks, 87 lines checked
b285256865f3 snd/hda: Protect concurrent display_power_status with a mutex
-:21: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#21: FILE: include/sound/hdaudio.h:371:
+	struct mutex display_power_lock;

total: 0 errors, 0 warnings, 1 checks, 38 lines checked



More information about the Intel-gfx mailing list