[Intel-gfx] [PATCH 2/3] snd/hda: Track the display_power_status using a cookie

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 14 21:11:48 UTC 2019


Quoting Takashi Iwai (2019-01-14 17:54:08)
> On Mon, 14 Jan 2019 18:37:52 +0100,
> Chris Wilson wrote:
> > diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> > index b4fa1c775251..39761120ee76 100644
> > --- a/include/sound/hdaudio.h
> > +++ b/include/sound/hdaudio.h
> > @@ -366,8 +366,8 @@ struct hdac_bus {
> >  
> >       /* DRM component interface */
> >       struct drm_audio_component *audio_component;
> > -     long display_power_status;
> > -     bool display_power_active;
> > +     unsigned long display_power_status;
> 
> You don't need to change this field.  It's irrelevant with this patch
> itself.

It kept the length of the two variables the same, while matching the
type as used with set_bit/clear_bit :)
-Chris


More information about the Intel-gfx mailing list