[Intel-gfx] [PATCH 00/17] drm/i915: switch to kernel fixed size types

Jani Nikula jani.nikula at intel.com
Wed Jan 16 09:15:18 UTC 2019


Hi all -

I haven't cared all that much about using C99 fixed size types (uint32_t
etc.) in the driver in addition to kernel types, as long as only one or
the other is used in the same struct/function/file. But the increasing
mixed use crossed some OCD threshold the other day. It gets ugly, and
sets a precedent that mixed use is fine.

Let's switch to kernel types exclusively, shall we?

Each path in the series is independent of the others, and it's mostly
one patch per file, apart from the first patch which gathers all the
isolated uses into one patch. I've tried to order the series from least
to most likely to cause conflicts with in-flight work per gut feeling.

Please holler if you think some of these patches need to wait for some
other, more important stuff to land first. This was mostly scripted,
with a few manual edits on top, so pretty quick to redo on top later.

After most of these have landed, I intend to drop PREFER_KERNEL_TYPES
from the checkpatch ignore list, and enforce.

BR,
Jani.


Jani Nikula (17):
  drm/i915: small isolated c99 types to kernel types switch
  drm/i915/crt: switch to kernel types
  drm/i915/sdvo: switch to kernel types
  drm/i915/lspcon: switch to kernel types
  drm/i915/debugfs: switch to kernel types
  drm/i915/irq: switch to kernel types
  drm/i915/cdclk: switch to kernel types
  drm/i915/dpll_mgr: switch to kernel types
  drm/i915/dp: switch to kernel types
  drm/i915/sprite: switch to kernel types
  drm/i915/color: switch to kernel types
  drm/i915/pm: switch to kernel types
  drm/i915/ddi: switch to kernel types
  drm/i915/csr: switch to kernel types
  drm/i915/display: switch to kernel types
  drm/i915/i915_drv.h: switch to kernel types
  drm/i915/intel_drv.h: switch to kernel types

 drivers/gpu/drm/i915/i915_debugfs.c           |  22 +-
 drivers/gpu/drm/i915/i915_drv.h               | 158 ++++++-------
 drivers/gpu/drm/i915/i915_gem.c               |  14 +-
 drivers/gpu/drm/i915/i915_gem_fence_reg.c     |   8 +-
 drivers/gpu/drm/i915/i915_gpu_error.c         |  10 +-
 drivers/gpu/drm/i915/i915_irq.c               |  82 +++----
 drivers/gpu/drm/i915/i915_perf.c              |   2 +-
 drivers/gpu/drm/i915/i915_reg.h               |   4 +-
 drivers/gpu/drm/i915/intel_atomic.c           |   4 +-
 drivers/gpu/drm/i915/intel_atomic_plane.c     |   4 +-
 drivers/gpu/drm/i915/intel_cdclk.c            |  40 ++--
 drivers/gpu/drm/i915/intel_color.c            |  40 ++--
 drivers/gpu/drm/i915/intel_crt.c              |  22 +-
 drivers/gpu/drm/i915/intel_csr.c              |  68 +++---
 drivers/gpu/drm/i915/intel_ddi.c              |  52 ++---
 drivers/gpu/drm/i915/intel_display.c          | 104 ++++-----
 drivers/gpu/drm/i915/intel_dp.c               | 142 ++++++------
 drivers/gpu/drm/i915/intel_dp_link_training.c |  32 +--
 drivers/gpu/drm/i915/intel_dp_mst.c           |   2 +-
 drivers/gpu/drm/i915/intel_dpio_phy.c         |  18 +-
 drivers/gpu/drm/i915/intel_dpll_mgr.c         | 145 ++++++------
 drivers/gpu/drm/i915/intel_dpll_mgr.h         |  53 +++--
 drivers/gpu/drm/i915/intel_drv.h              |  94 ++++----
 drivers/gpu/drm/i915/intel_engine_cs.c        |  12 +-
 drivers/gpu/drm/i915/intel_fbc.c              |   2 +-
 drivers/gpu/drm/i915/intel_fifo_underrun.c    |  12 +-
 drivers/gpu/drm/i915/intel_hdcp.c             |   4 +-
 drivers/gpu/drm/i915/intel_lrc.c              |   2 +-
 drivers/gpu/drm/i915/intel_lspcon.c           |  20 +-
 drivers/gpu/drm/i915/intel_pipe_crc.c         |  18 +-
 drivers/gpu/drm/i915/intel_pm.c               | 213 +++++++++---------
 drivers/gpu/drm/i915/intel_psr.c              |   6 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h       |   2 +-
 drivers/gpu/drm/i915/intel_runtime_pm.c       |  20 +-
 drivers/gpu/drm/i915/intel_sdvo.c             |  78 +++----
 drivers/gpu/drm/i915/intel_sprite.c           |  60 ++---
 36 files changed, 782 insertions(+), 787 deletions(-)

-- 
2.20.1



More information about the Intel-gfx mailing list