[Intel-gfx] [PATCH 00/17] drm/i915: switch to kernel fixed size types

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 16 09:22:46 UTC 2019


Quoting Jani Nikula (2019-01-16 09:15:18)
> Hi all -
> 
> I haven't cared all that much about using C99 fixed size types (uint32_t
> etc.) in the driver in addition to kernel types, as long as only one or
> the other is used in the same struct/function/file. But the increasing
> mixed use crossed some OCD threshold the other day. It gets ugly, and
> sets a precedent that mixed use is fine.
> 
> Let's switch to kernel types exclusively, shall we?
> 
> Each path in the series is independent of the others, and it's mostly
> one patch per file, apart from the first patch which gathers all the
> isolated uses into one patch. I've tried to order the series from least
> to most likely to cause conflicts with in-flight work per gut feeling.
> 
> Please holler if you think some of these patches need to wait for some
> other, more important stuff to land first. This was mostly scripted,
> with a few manual edits on top, so pretty quick to redo on top later.
> 
> After most of these have landed, I intend to drop PREFER_KERNEL_TYPES
> from the checkpatch ignore list, and enforce.
> 
> BR,
> Jani.
> 
> 
> Jani Nikula (17):
>   drm/i915: small isolated c99 types to kernel types switch
>   drm/i915/crt: switch to kernel types
>   drm/i915/sdvo: switch to kernel types
>   drm/i915/lspcon: switch to kernel types
>   drm/i915/debugfs: switch to kernel types
>   drm/i915/irq: switch to kernel types
>   drm/i915/cdclk: switch to kernel types
>   drm/i915/dpll_mgr: switch to kernel types
>   drm/i915/dp: switch to kernel types
>   drm/i915/sprite: switch to kernel types
>   drm/i915/color: switch to kernel types
>   drm/i915/pm: switch to kernel types
>   drm/i915/ddi: switch to kernel types
>   drm/i915/csr: switch to kernel types
>   drm/i915/display: switch to kernel types
>   drm/i915/i915_drv.h: switch to kernel types
>   drm/i915/intel_drv.h: switch to kernel types

Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

I've reviewed the patches that touch the code I work with most, leaving
the display chunks which have the majority preference for stdint.
-Chris


More information about the Intel-gfx mailing list