[Intel-gfx] [PATCH v2 1/4] drm/i915/dp: remove PANEL_POWER_OFF macro and its use

[Jani Nikula]

On Thu, 17 Jan 2019, Mika Kuoppala <mika.kuoppala at linux.intel.com> wrote:
> Jani Nikula <jani.nikula at intel.com> writes:
>
>> It's superfluous.
>
> One could argue that it has a minor documentative purpose.
> But there is comment for that.
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

Thanks, pushed this one.

BR,
Jani.

>
>>
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_reg.h | 1 -
>>  drivers/gpu/drm/i915/intel_dp.c | 3 +--
>>  2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index 9a1340cfda6c..93cbd057c07a 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -4687,7 +4687,6 @@ enum {
>>  #define  EDP_FORCE_VDD			(1 << 3)
>>  #define  EDP_BLC_ENABLE			(1 << 2)
>>  #define  PANEL_POWER_RESET		(1 << 1)
>> -#define  PANEL_POWER_OFF		(0 << 0)
>>  #define  PANEL_POWER_ON			(1 << 0)
>>  
>>  #define _PP_ON_DELAYS			0x61208
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 808ccdae15b8..f7d5314e3395 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -1000,8 +1000,7 @@ static int edp_notify_handler(struct notifier_block *this, unsigned long code,
>>  
>>  			/* 0x1F write to PP_DIV_REG sets max cycle delay */
>>  			I915_WRITE(pp_div_reg, pp_div | 0x1F);
>> -			I915_WRITE(pp_ctrl_reg,
>> -				   PANEL_UNLOCK_REGS | PANEL_POWER_OFF);
>> +			I915_WRITE(pp_ctrl_reg, PANEL_UNLOCK_REGS);
>>  			msleep(intel_dp->panel_power_cycle_delay);
>>  		}
>>  	}
>> -- 
>> 2.20.1
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center