[Intel-gfx] [PATCH 2/5] drm/i915: always return something

Kahola, Mika mika.kahola at intel.com
Tue Jan 22 12:01:27 UTC 2019


Patch look ok to me.

On Thu, 2019-01-17 at 12:21 -0800, Lucas De Marchi wrote:
> Even if we don't have the correct clock and get a warning, we should
> not
> skip the return.
> 
> Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Cc: <stable at vger.kernel.org> # v4.19+

Reviewed-by: Mika Kahola <mika.kahola at intel.com>

> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 8dbf6c9e22fb..4dc03e8c6c10 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct
> intel_encoder *encoder,
>  			return DDI_CLK_SEL_TBT_810;
>  		default:
>  			MISSING_CASE(clock);
> -			break;
> +			return DDI_CLK_SEL_NONE;
>  		}
>  	case DPLL_ID_ICL_MGPLL1:
>  	case DPLL_ID_ICL_MGPLL2:


More information about the Intel-gfx mailing list