[Intel-gfx] [PATCH v8 4/7] drm/i915: use a macro to define MOCS entries

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 22 14:32:21 UTC 2019


Quoting Lucas De Marchi (2019-01-22 05:12:24)
> Let's use a macro to make tables smaller and at the same time allow us
> to add fields that apply to all entries in future.
> 
> For the sake of readability, I'm calling an exception on 80 chars limit.
> Lines are aligned for easy comparison of the entry values.

> +       MOCS_ENTRY(I915_MOCS_UNCACHED,  LE_1_UC | LE_TC_2_LLC_ELLC, \
> +                                       L3_1_UC), \

          MOCS_ENTRY(I915_MOCS_UNCACHED,
		     LE_1_UC | LE_TC_2_LLC_ELLC, L3_1_UC), \

is even more readable with the visual clustering of attribute flags.
-Chris


More information about the Intel-gfx mailing list