[Intel-gfx] [v6 0/6] Add support for Gen 11 pipe color features

Shankar, Uma uma.shankar at intel.com
Fri Jan 25 12:35:43 UTC 2019



>-----Original Message-----
>From: Shankar, Uma
>Sent: Wednesday, January 16, 2019 9:52 PM
>To: intel-gfx at lists.freedesktop.org
>Cc: Lankhorst, Maarten <maarten.lankhorst at intel.com>; Syrjala, Ville
><ville.syrjala at intel.com>; Sharma, Shashank <shashank.sharma at intel.com>;
>Roper, Matthew D <matthew.d.roper at intel.com>; Shankar, Uma
><uma.shankar at intel.com>
>Subject: [v6 0/6] Add support for Gen 11 pipe color features
>
>This patch series adds support for Gen11 pipe degamma, CSC and gamma
>hardware blocks.

Ping !!!

>CRC checks are not working for 10bit gamma but works for 8bit pallete modes
>which seems to be due to some rounding errors in pipe. Also there is a corner
>case where Lut precision is increased to 3.16, hence its not possible to accurately
>represent 1.0 which will require 17 bits. Support for extending the ABI is already in
>discussion in below series:
>https://patchwork.freedesktop.org/patch/249771/
>
>ToDo: Support for Multi Segmented Gamma will be added later.
>
>v2: Addressed Maarten's review comments and re-ordered the patch series.
>
>v3: Addressed Matt's review comments. Removed rmw patterns as suggested by
>Matt.
>
>v4: Addressed Matt's review comments.
>
>v5: Addressed Matt's, Ville and Jani Nikula's review comments.
>
>v6: Addressed Matt and Ville's review comments. Extended GLK degamma
>function and merged ICL degamma support to that. Handled pipe output csc
>separately along with regular pipe csc. Dropped gamma_mode removal patch as
>Ville is using that to refactor the gamma handling. This series may need a rebase
>on top of Ville's below series:
>https://patchwork.freedesktop.org/series/55081/.
>
>Uma Shankar (6):
>  drm/i915: Sanitize crtc gamma and csc mode
>  drm/i915/glk: Fix degamma lut programming
>  drm/i915/icl: Add icl pipe degamma and gamma support
>  drm/i915/icl: Enable ICL Pipe CSC block
>  drm/i915/icl: Enable pipe output csc
>  drm/i915/icl: Add degamma and gamma lut size to gen11 caps
>
> drivers/gpu/drm/i915/i915_pci.c      |   5 +-
> drivers/gpu/drm/i915/i915_reg.h      |  62 +++++++++++++---
> drivers/gpu/drm/i915/intel_color.c   | 133 ++++++++++++++++++++++++++++----
>---
> drivers/gpu/drm/i915/intel_display.c |  21 ++++++
> drivers/gpu/drm/i915/intel_drv.h     |   3 +
> 5 files changed, 188 insertions(+), 36 deletions(-)
>
>--
>1.9.1



More information about the Intel-gfx mailing list